popupMenu: Treat a menu will all invisible menu items as empty

As an example, a menu that has only settings actions might
be "empty" if allowSettings is false.

https://bugzilla.gnome.org/show_bug.cgi?id=681540

diff --git a/js/ui/popupMenu.js b/js/ui/popupMenu.js
index 9807b627521fb1c4484f48f7b1b90c484dcc40e7..5123696f332b738a2d1d92c3c8b68dd5658e1089 100644 (file)
--- a/js/ui/popupMenu.js
+++ b/js/ui/popupMenu.js
@@ -914,7 +914,11 @@ const PopupMenuBase = new Lang.Class({
     },
 
     isEmpty: function() {
-        return this.box.get_n_children() == 0;
+        let hasVisibleChildren = this.box.get_children().some(function(child) {
+            return child.visible;
+        });
+
+        return !hasVisibleChildren;
     },
 
     isChildMenu: function(menu) {